| Thread Previous • Date Previous • Date Next • Thread Next |
Le 20/11/2012 15:16, Joël Grand-Guillaume a écrit :
So my question here is, would you all agree to accept the following people/teams to be part of the new "OpenERP Community Reviewer" ?- Camptocamp Community Reviewer (Alexandre Fayolle, Guewen Baconnier, Nicolas Bessi, and me)- Nhomar Hernandez (Vauxoo) - Raphaël Valyi (Akretion) - Stefan Rijnhart (Therp) - Olivier Dony (OpenERP) I would also suggest : - Borja López Soilán (Neoplus) - Omar (Pexego) - Maxime Chambreuil (Savoir faire linux) - Jordi Esteve (Zikzakmedia)Well, I'm sure I forgot to add lots of good people here, excuse me for that, those are the names that came to me. Any suggestion is welcome, just post a mail !
I think that the list you propose for the "OpenERP community reviewer" group is way too small ! With what you propose, we are moving from a situation where the group of commiters for the extra-addons was wide open and had a lot of people, to a situation where only a very small subset of OpenERP community developers has direct access to the source code. I am afraid that, in the new situation, the merge proposals will take too much time to be approved/merged. Your list only has 12 people ; they are all extremely busy and they would do this review work in parallel of their paid work for their OpenERP customers.
I don't want the community modules of OpenERP to be in the situation of the official modules of OpenERP, where a lot of merge proposal are not reviewed. I used to do a lot of merge proposals on addons/trunk, but I stopped a few months ago because a number of my merge proposal never got any review and it destroyed my motivation to take time on my evenings and week-ends to work on new merge proposals for addons/trunk (it's not the ideas for improvements that are lacking, I can tell you !).
Here is an example of my merge proposals that never got any comment nor review : 14/07/2012 : https://code.launchpad.net/~akretion-team/openobject-addons/trunk-addons-harmonize-noupdate-on-security/+merge/114987 27/07/2012 : https://code.launchpad.net/~akretion-team/openobject-addons/trunk-addons-do-not-jump-to-product-template/+merge/117089 05/08/2012 : https://code.launchpad.net/~akretion-team/openobject-addons/trunk-payment-term-on-purchase-v4/+merge/118256
In July, we had so many not-reviewed merge proposals for trunk that we traveled to Grand-Rosière to "push on the merge button" and we hopefully obtained a lot of merges on trunk.
The OpenERP community should absolutely avoid to the danger of having un-reviewed merge proposals because the group of reviewer is too small and too overworked (this is the current situation on addons/trunk), because community developers would loose their motivation to contribute and/or move to other free software projects. We really don't want that !
-- Alexis
| Thread Previous • Date Previous • Date Next • Thread Next |
