← Back to team overview

openerp-community team mailing list archive

Re: [Merge] lp:~openerp-community/web-addons/7.0-web_color into lp:~webaddons-core-editors/web-addons/7.0

 

Hi,

Nice module.

76	+ 'auto_install': True,

It means that the module will be automatically installed once someone put the web-addons branch in its addons-path.
I don't think that is advised for community branches. One may need to use the branch for another module, and he would have no choice to have the `auto_install` modules installed.

What do you think about that ?


875	+ var _t = openerp.web._t;
876	+ var QWeb = openerp.web.qweb;
They are not used


880	+ instance.web.form.widgets.add(widget_name, 'openerp.web_color'); 
Does it work? Does not the widget have to extend a field which implement the necessary functions (render_value, focus, ...)?


-- 
https://code.launchpad.net/~openerp-community/web-addons/7.0-web_color/+merge/136214
Your team OpenERP Community is subscribed to branch lp:~openerp-community/web-addons/7.0-web_color.


References