openerp-community team mailing list archive

["Olivier Dony \(OpenERP\)" <odo@xxxxxxxxxxx>]

Review: Needs Fixing

Thanks for the bug report and the patch.

One small thing is incorrect (and was in fact not correct in the original code either): when resolving external IDs with ir.model.data.get_object_reference() there is always a chance of getting a ValueError if the record has been manually deleted in the database, which is quite possible.
Hence testing the result for falsiness is not correct, it must be replaced by a try/except guard with a proper fallback value, as done here for example: http://bazaar.launchpad.net/~openerp/openobject-addons/7.0/view/8599/sale/sale.py#L609

Thanks!
-- 
https://code.launchpad.net/~openerp-community/openobject-addons/fix-1100271-membership-invoice-form-view/+merge/143504
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/fix-1100271-membership-invoice-form-view.