openerp-community team mailing list archive

[Joël Grand-Guillaume @ camptocamp <joel.grandguillaume@xxxxxxxxxxxxxx>]

Review: Needs Fixing code review, no test

Hello Maxime,


Thank for this contrib. I just saw that Nicolas posted this one: https://code.launchpad.net/~partner-contact-core-editors/partner-contact-management/7.0-partner_firstname/+merge/143077

I'm waiting his infos (he's on holiday, coming back on monday) to know which one we keep.

Little comments:

 * You should use # -*- coding: utf-8 -*- instead of : # -*- encoding: utf-8 -*-

 * You can remove the class instanciation (line : 759, 916, 1068, 1152

 * Better to use from openerp.osv import orm, fields class ResPartner(orm.Model)

 * On line 733 and 747, you should IMO mark the kwargs to avoid potential trouble on the context like e.g. : return super(res_partner_address, self).create(cr, uid, vals, context=context)


Have a nice week-end,

Regards,

Joël
-- 
https://code.launchpad.net/~openerp-community/partner-contact-management/base_partner_surname/+merge/149651
Your team OpenERP Community is subscribed to branch lp:~openerp-community/partner-contact-management/base_partner_surname.