openerp-community team mailing list archive

[Joël Grand-Guillaume @ camptocamp <joel.grandguillaume@xxxxxxxxxxxxxx>]

Review: Approve code review, no test

Hi Maxime, thanks to resumbit only one module !

Little comments:

* You should use # -*- coding: utf-8 -*- instead of : # -*- encoding: utf-8 -*-

* You can remove the class instanciation on line : 759

* Better to use from openerp.osv import orm, fields class ResPartnerAddress(orm.Model)

* On line 733 and 747, you should IMO mark the kwargs to avoid potential trouble on the context like e.g. : return super(res_partner_address, self).create(cr, uid, vals, context=context)

Otherwise, it LGTM. I mark it as approved as the comments are more related to the v7.0 coding standard, but it would be may be good to correct them here directly... As you wish.

Regards,

Joël
-- 
https://code.launchpad.net/~openerp-community/partner-contact-management/base_partner_surname/+merge/150168
Your team OpenERP Community is subscribed to branch lp:~openerp-community/partner-contact-management/base_partner_surname.