openerp-community team mailing list archive

[Joao Alfredo Gama Batista <joao.gama@xxxxxxxxxxxxxxxxxxxx>]

The typos have been corrected. Thanks for pointing it out.

About the pep8 review. A fair share of the pep8 rules were made to improve the code readability but, in some cases we may end up losing readability by breaking a complex line just to be pep8 clean. I'm all up for pep8 but the E501 thing is a more controversial subject.

> You have typos at line 169 and 191 : dependecies -> dependencies
> 
> $ flake8 .
> ./__init__.py:23:1: F401 'product' imported but unused
> ./__openerp__.py:27:80: E501 line too long (273 > 79 characters)
> ./__openerp__.py:33:41: W291 trailing whitespace
> ./product.py:60:80: E501 line too long (96 > 79 characters)
> ./product.py:68:80: E501 line too long (98 > 79 characters)
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/openerp-product-attributes/product_dependencies/+merge/185082
Your team OpenERP Community is subscribed to branch lp:openerp-product-attributes.