openerp-community team mailing list archive

[Niels Huylebroeck <niels@xxxxxxxxxxxxx>]

A quick check with flake8 produces only one easily fixable style suggestion:
http://pastie.org/8336327

The space after the comma.

For all the other "problems" it's nagging about the 79 character limit.
Since no lines are longer than 100 characters this is a minimal discomfort imho and restructuring the code manually takes a long time.

Yes the long lines indicate a non-optimal writing. This is code that has been ported, not written from scratch.

Feel free to branch and commit (it's pushed to ~openerp-community team) and start cleaning up. Keep in mind that the larger the commit message the more time it takes to approve it.

Consider also that changing the indentation/line length will not necessarily produce cleaner code but can introduce errors in logic unless you are very careful or use automated tools.

Formatting tools (autopep8) turn the file from somewhat hard to read to impossible to read with the tons of auto-indentation it adds, I think to get a clean result you can only do it manually.


-- 
https://code.launchpad.net/~openerp-community/openerp-product-variant/fix-pep8-and-relative-import/+merge/186351
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openerp-product-variant/fix-pep8-and-relative-import.