openerp-community team mailing list archive

Thread
Date

Re: lp:~agilebg/openerp-product-attributes/adding_product_pack_7 into lp:openerp-product-attributes

To: Lorenzo Battistini - Agile BG <lorenzo.battistini@xxxxxxxxxxx>
From: "Leonardo Pistone @ camptocamp" <leonardo.pistone@xxxxxxxxxxxxxx>
Date: Mon, 25 Nov 2013 16:44:38 -0000
In-reply-to: <20131119142655.3903.7292.launchpad@ackee.canonical.com>
Reply-to: mp+195786@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing code review, no test

Thank you Lorenzo, Alex.

- Translations, if they are old and/or incorrect, IMO we can remove them for now. You could leave whatever works for you (i.e. Italian) and remove everything else

- Defaults: lambda is not needed anymore

- I see some long, multi-line comments in the code. Maybe some could be moved in some more prominent place, like docstrings?

L
-- 
https://code.launchpad.net/~agilebg/openerp-product-attributes/adding_product_pack_7/+merge/195786
Your team OpenERP Community is subscribed to branch lp:openerp-product-attributes.

References

[Merge] lp:~agilebg/openerp-product-attributes/adding_product_pack_7 into lp:openerp-product-attributes
From: Lorenzo Battistini - Agile BG, 2013-11-19