← Back to team overview

openerp-community team mailing list archive

Re: Style: dictionaries

 

I also prefer second one for dictionaries.

Regards.


2013/12/4 Andreas Maertens <am@xxxxxx>

> I prefer second.
> often it looks like:
>
> context = {
>     'item1' : item1,
>     'item2' : item2,
> }
>
> this is much better to read in source.
>
> lists are different. they might be better like second when having long
> written items. if having short items, one liners are okay.
> but first from the dicts look weired. imho we should avoid thad.
>
>
> Von Samsung Mobile gesendet
>
>
>
> -------- Ursprüngliche Nachricht --------
> Von: Nicola Riolini <nicola.riolini@xxxxxxxxx>
> Datum: 04.12.2013 17:41 (GMT+01:00)
> An: openerp-community@xxxxxxxxxxxxxxxxxxx
> Betreff: Re: [Openerp-community] Style: dictionaries
>
>
> both 4 me, but with the comma (,) after the second element, for don't
> forget if I append other ones'
>
> On 04/12/2013 17:28, Francesco Apruzzese wrote:
>
> The second one is the best for me.
>
> Nella citazione in data mer 04 dic 2013 17:24:37 CET, Leonardo Pistone ha
> scritto:
>
> Hi all,
> I bring to your attention Sandy's review here:
>
>
> https://code.launchpad.net/~camptocamp/stock-logistic-flows/6.1-add-mrp_open_lot_attributes-lep/+merge/196749
>
> <https://code.launchpad.net/%7Ecamptocamp/stock-logistic-flows/6.1-add-mrp_open_lot_attributes-lep/+merge/196749><https://code.launchpad.net/%7Ecamptocamp/stock-logistic-flows/6.1-add-mrp_open_lot_attributes-lep/+merge/196749>
>
> according to pep8, two styles of indentation are possible. Take for
> example a dictionary:
>
> {'name': 'spam',
>  'color': 'brown'
>  }
>
> or
>
> {
>     'name': 'eggs',
>     'color': 'white'
> }
>
> According to the pep8 document and to the pep8 checker, they both
> work. I personally would accept both.
>
> What do you think?
>
> Best, Leo
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openerp-community
> Post to     : openerp-community@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~openerp-community
> More help   : https://help.launchpad.net/ListHelp
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openerp-community
> Post to     : openerp-community@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~openerp-community
> More help   : https://help.launchpad.net/ListHelp
>
>
> --
>  <http://www.micronaet.it/>
>
>
> nicola riolini
> [area tecnica]
>
> [image: Concessionario Autorizzato Passepartout Mexal]<http://www.micronaet.it/>micronaet s.r.l.
>
> sede operativa:
> via iv novembre 264
> 25010 borgosatollo (bs)
>
> tel./fax +39 030 2501517
>
>  [image: Skype Status] call me skype (utente skype: rn.micronaet)
>
> ATTENZIONE: Il contenuto di questo messaggio e rivolto unicamente alle
> persone cui è indirizzato e può contenere informazioni la cui riservatezza
> è tutelata legalmente. Ne sono vietati la riproduzione, la diffusione e
> l'uso in mancanza di autorizzazione del destinatario. Se l'avete ricevuto
> per errore vogliate eliminare il messaggio in modo permanente e darcene
> cortesemente notizia. Analizzate sempre gli allegati prima di aprirli.
>
>
>
> ____________
> Virus checked by G Data AntiVirus
> Version: AVA 22.14249 dated 04.12.2013
> Virus news: www.antiviruslab.com
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openerp-community
> Post to     : openerp-community@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~openerp-community
> More help   : https://help.launchpad.net/ListHelp
>
>

References