← Back to team overview

openerp-community team mailing list archive

Thread
Date

Re: lp:~camptocamp/openerp-product-attributes/6.1-search-all-prodlot-attributes-lep into lp:openerp-product-attributes/6.1

To: "Leonardo Pistone @ camptocamp" <leonardo.pistone@xxxxxxxxxxxxxx>
From: "Guewen Baconnier @ Camptocamp" <guewen.baconnier@xxxxxxxxxxxxxx>
Date: Thu, 19 Dec 2013 08:32:23 -0000
In-reply-to: <20131217181036.23898.86271.launchpad@ackee.canonical.com>
Reply-to: mp+199335@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code review

Great! thanks.

l.102 
I think that 
    itertools.chain.from_iterable(expand(arg) for arg in args)
is better (does not create intermediate lists)

-- 
https://code.launchpad.net/~camptocamp/openerp-product-attributes/6.1-search-all-prodlot-attributes-lep/+merge/199335
Your team OpenERP Community is subscribed to branch lp:openerp-product-attributes/6.1.

References

lp:~camptocamp/openerp-product-attributes/6.1-search-all-prodlot-attributes-lep into lp:openerp-product-attributes/6.1
From: Leonardo Pistone @ camptocamp, 2013-12-17