openerp-community team mailing list archive

[Denis Karataev <dskarataev@xxxxxxxxx>]

I subscribed Olivier Dony and openerp-community list for notifications
of this bug. Please pay attention to it.

The problem in two words is that OpenERP highly restrict us with email
addresses we can use for users. So we can't use for example:
123456@xxxxxxxxx, me@xxxxxxxxxxxxx, admin@xxxxxxxxxx etc. It's why we
can't add a portal user for customer if its email doesn't match to this
ugly designed expression.

Please, keep in mind that this bug also posted in July, so it's already
6 months ago! Does everyone like that time of bugs consideration?

-- 
You received this bug notification because you are a member of OpenERP
Community, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1199386

Title:
  Email address regular expression needs work

Status in OpenERP Addons (modules):
  New
Status in OpenERP Server:
  New

Bug description:
  During testing with my email-address 'm@xxxxxxxxxxxxxx'  I noticed a
  couple of things:

  1. The partner contact with that email-address can't be given access
  to the portal by the portal wizard, it fails on creation of the user
  in addons/mail/res_user.py:68 :

          if not data.get('login', False):
              raise osv.except_osv(_('Invalid Action!'),...)))

  2. The login field is empty, because the portal wizard uses the email
  field to create a login in addons/portal/wizard/portal_wizard.py:177
  :

              'login': extract_email(wizard_user.email),

  The extract_email function in portal_wizard.py uses 'email_re' to determine what the login field should look like.
  'email_re' is defined as in multiple places, which is the first problem. It at least in  tools/mail.py and tools/import_email.py. (The latter contains email information from the 'steel-sa.com ' (?!?) domain by the way.)

  email_re = re.compile(r"""
      ([a-zA-Z][\w\.-]*[a-zA-Z0-9]     # username part
      @                                                          # mandatory @ sign
      [a-zA-Z0-9][\w\.-]*                       # domain must start with a letter ... Ged> why do we include a 0-9 then?
       \.
       [a-z]{2,3}                      # TLD
      )
      """, re.VERBOSE)

  Problems I see:

  1. The email_re is defined in multiple places; make it one;
  2. It forces to have email-addresses with at least 2 characters for the user part, of which the first must contain a letter; addresses like m@xxxxxxxxxx won't work then; is there a reason for this?
  3. the TLD must contain 2 or 3 characters, which is unsuitable for domains like .name or .info

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/1199386/+subscriptions