openerp-community team mailing list archive

[Sandy Carter <sandy.carter@xxxxxxxxxxxxxxxxxxxx>]

Hi thank you for your module,

At first glance, on a technical standpoint, I have to give this +1 since 
it passes OpenERP's tests, which partner_firstname doesn't.

However, this module needs a bit of fixing since it is using deprecated 
code (e.g. osv.osv, res_users(), "active", "demo_xml"), has PEP8 issues, 
unused imports and uses _name unnecessarily.

This can all be fixed easily.

Le 2014-01-22 15:42, Yury Tello a écrit :
> Hi Maxime, may be the module base_person would be an option.
> https://www.openerp.com/apps/7.0/base_person/
>
> Best Regards
>
>
> 2014/1/22 Maxime Chambreuil <maxime.chambreuil@xxxxxxxxxxxxxxxxxxxx
> <mailto:maxime.chambreuil@xxxxxxxxxxxxxxxxxxxx>>
>
>     Hello everyone,
>
>     I think we have few problems in regards to partner_firstname :
>     https://bugs.launchpad.net/partner-contact-management
>
>     As I am not convinced on the current implementation, I have started
>     a blueprint to discuss the options and decide on a solution :
>     https://blueprints.launchpad.net/partner-contact-management/+spec/partner-firstname
>
>     Feel free to join.
>     --
>     Maxime Chambreuil
>     +1 (514) 276-5468 #126
>
>
>     _______________________________________________
>     Mailing list: https://launchpad.net/~openerp-community
>     Post to     : openerp-community@xxxxxxxxxxxxxxxxxxx
>     <mailto:openerp-community@xxxxxxxxxxxxxxxxxxx>
>     Unsubscribe : https://launchpad.net/~openerp-community
>     More help   : https://help.launchpad.net/ListHelp
>
>
>
>
> --
> Yury Tello Canchapoma
> TeraData SAC
> http://www.teradata.com.pe
> Telecomunicaciones, Software & Seguridad
>
> Telef.:(+51 1) 5362222 anexo 20
> Av. Arenales 395 Of. 507 - Lima 1 - Peru
>
>
>
> --
> Yury Tello Canchapoma
> TeraData SAC
> http://www.teradata.com.pe
> Telecomunicaciones, Software & Seguridad
>
> Telef.:(+51 1) 5362222 anexo 20
> Av. Arenales 395 Of. 507 - Lima 1 - Peru
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openerp-community
> Post to     : openerp-community@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~openerp-community
> More help   : https://help.launchpad.net/ListHelp