openerp-community team mailing list archive

["Sandy Carter \(http://www.savoirfairelinux.com\)" <sandy.carter@xxxxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing



Diff comments:

> === modified file 'l10n_ca_hr_payroll/__openerp__.py'
> --- l10n_ca_hr_payroll/__openerp__.py	2013-02-27 20:02:47 +0000
> +++ l10n_ca_hr_payroll/__openerp__.py	2014-06-11 15:00:16 +0000
> @@ -38,6 +38,7 @@
>          'l10n_ca_toponyms',
>      ],
>      'data': [
> +        'security/ir.model.access.csv',
>          'l10n_ca_hr_payroll_view.xml',
>          'l10n_ca_hr_payroll_data.xml',
>      ],
> 
> === added directory 'l10n_ca_hr_payroll/security'
> === added file 'l10n_ca_hr_payroll/security/ir.model.access.csv'
> --- l10n_ca_hr_payroll/security/ir.model.access.csv	1970-01-01 00:00:00 +0000
> +++ l10n_ca_hr_payroll/security/ir.model.access.csv	2014-06-11 15:00:16 +0000
> @@ -0,0 +1,7 @@
> +id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
> +access_hr_payroll_tax_table,access_hr_payroll_tax_table,model_hr_payroll_tax_table,,1,1,1,1

group_id:id column is empty in every one of these lines.
You actually have to put in a group here.

> +access_hr_payroll_tax_table_federal_line,access_hr_payroll_tax_table_federal_line,model_hr_payroll_tax_table_federal_line,,1,1,1,1
> +access_hr_payroll_tax_table_ei_line,access_hr_payroll_tax_table_ei_line,model_hr_payroll_tax_table_ei_line,,1,1,1,1
> +access_hr_payroll_tax_table_qc_line,access_hr_payroll_tax_table_qc_line,model_hr_payroll_tax_table_qc_line,,1,1,1,1
> +access_hr_payroll_tax_table_rqap_line,access_hr_payroll_tax_table_rqap_line,model_hr_payroll_tax_table_rqap_line,,1,1,1,1
> +access_hr_payroll_tax_table_csst_line,access_hr_payroll_tax_table_csst_line,model_hr_payroll_tax_table_csst_line,,1,1,1,1
> \ No newline at end of file
> 


-- 
https://code.launchpad.net/~openerp-community/openerp-canada/7.0-missing-payroll-access/+merge/222815
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openerp-canada/7.0-missing-payroll-access.