← Back to team overview

openerp-connector-community team mailing list archive

magentoerconnect / sale order

 

Hi all,

Just few words about inconsistency in field name 'magento_order_id' in
sale order.

we have this field name in magento.sale.order with integer type
http://bazaar.launchpad.net/~openerp-connector-core-editors/openerp-connector-magento/7.0/view/head:/magentoerpconnect/sale.py#L80

we have the same field in magento.sale.order.line with m2o type
http://bazaar.launchpad.net/~openerp-connector-core-editors/openerp-connector-magento/7.0/view/head:/magentoerpconnect/sale.py#L147

It's a little confusing but explained by Magento webservice full
confusing  (use increment_id and order_id data, #!ᎁߐߘꔞ?Anahaaꘐꗨᨒฐ)

We have the same case in our dev in magento sale comment and magento rma.

I propose either to rename it in magento_sale_order_id for the m2o
(sale.order.line) or to rename in sale.order model field in
magento_real_order_id or something better.

The first solution could be simpler.

What is the better choice ? or maybe change nothing ?

David BEAL
Akretion
OpenERP Development - Integration
+33 (0)6 67 22 86 89
+33 (0)4 82 53 84 60