← Back to team overview

openerp-connector-community team mailing list archive

Re: needs reviewer

 

Hi Guewen,

No problem but i thought any merge request needs at least two reviewer
approval. I saw your approval but i was waiting a second one.

Sorry

I will change the branch

Thank you


David BEAL
Akretion
OpenERP Development - Integration
+33 (0)6 67 22 86 89
+33 (0)4 82 53 84 60


2014-02-14 10:12 GMT+01:00 Guewen Baconnier <guewen.baconnier@xxxxxxxxxxxxxx>:
> Hi David,
>
> I approved your proposals. Excepted the last one that has a wrong target branch.
>
> I try to group all the merges that requires an update of the modules
> (schema or view changes) in one major release, this explain why I may
> take some time
> before merging proposals such as your one.
>
> That said, more reviews are still welcome :-)
> Guewen Baconnier
> Business Solutions Software Developer
>
> Camptocamp SA
> PSE A, CH-1015 Lausanne
> Phone: +41 21 619 10 39
> Office: +41 21 619 10 10
> http://www.camptocamp.com/
>
>
> On Fri, Feb 14, 2014 at 10:00 AM, David Beal <david.beal@xxxxxxxxxxxx> wrote:
>> Prevoius merge request are affiliated to these
>>
>> https://code.launchpad.net/~akretion-team/openerp-connector-magento/connector-magento-fix-product-view-dbl/+merge/204709
>> https://code.launchpad.net/~akretion-team/openerp-connector/connector-ecommerce-without-product-view-dbl/+merge/204707
>>
>> David BEAL
>> Akretion
>> OpenERP Development - Integration
>> +33 (0)6 67 22 86 89
>> +33 (0)4 82 53 84 60
>>
>>
>> 2014-02-14 9:50 GMT+01:00 David Beal <david.beal@xxxxxxxxxxxx>:
>>> damned
>>>
>>> i have forgot the url
>>>
>>> https://code.launchpad.net/~akretion-team/openerp-connector/connector-base-product/+merge/204706
>>>
>>> David BEAL
>>> Akretion
>>> OpenERP Development - Integration
>>> +33 (0)6 67 22 86 89
>>> +33 (0)4 82 53 84 60
>>>
>>>
>>> 2014-02-14 9:33 GMT+01:00 David Beal <david.beal@xxxxxxxxxxxx>:
>>>> Hello,
>>>>
>>>> Very small commit needs a reviewer
>>>>
>>>> Thank you
>>>>
>>>> David BEAL
>>>> Akretion
>>>> OpenERP Development - Integration
>>>> +33 (0)6 67 22 86 89
>>>> +33 (0)4 82 53 84 60
>>
>> --
>> Mailing list: https://launchpad.net/~openerp-connector-community
>> Post to     : openerp-connector-community@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~openerp-connector-community
>> More help   : https://help.launchpad.net/ListHelp


References