openerp-connector-community team mailing list archive

[Guewen Baconnier <guewen.baconnier@xxxxxxxxxxxxxx>]

Hi Markus,

On Mon, Apr 28, 2014 at 2:24 PM, Markus Schneider
<markus.schneider@xxxxxxxxxx> wrote:
> hi folks,
>
> with the discussion what option should be default how the connector
> should handle some data and thinking how to reuse and share more code i
> start making a concept to move different option in separate module and
> add option that the user can select.

Thanks for taking care of that. This is difficult to balance the
simplicity of the core addon / complexity of installation.
This is well to have a base module with only a few options not to lose
the users, but on the other hand, if we need to install a dozen of
modules, that could be a problem.
I'm really hesitant of what should be in the core or not. The code
complexity also rises when using modules.
Here, we could propose a default option (deactivate the product?) in
the core module and allow refinements when your module is installed.

>
> I start with the simple example on handling the disable flag of magento
> products. I saw the merge proposal from Jan but see that we can have a
> endless discussion in 3 lines of code. So i focus more on have a
> alternative solution.
>
> You find my code here:
>
> https://code.launchpad.net/~initos.com/openerp-connector-magento/7.0-magentoerpconnect_options_active/+merge/217423
>
> Some thoughts on that:
>
> - it would nice to add a option with a separate module. Example in my
> case: extending product.product with a boolean "not saleable online" and
> match Magento product active with this OpenERP option. But i guess this
> to fancy.
>
> - i use the replacing function, i m not sure if this is the best
> solution and multiple replacing will work or it is always working
> correctly if you have a customized connector type on that

I added a comment on the merge proposal, the multiple replacing would
not work, I proposed a workaround that we can discuss if it is not
clear enough. (BTW I'm thinking about a way to pipeline the mappers)

>
> For the moment i just want to move the discussion, from having one
> option as the default and fight want to having the widespread in the
> main repository without plug up the basic module.
>
> Kind Regards
>
> Markus
>
> --
> Dipl.-Comp.-Math. Markus Schneider
> Softwareentwickler
>
> initOS GmbH & Co. KG
> An der Eisenbahn 1
> 21224 Rosengarten

Guewen