openerp-dev-web team mailing list archive

["Olivier \(Open ERP\)" <olt@xxxxxxxxxxx>]

> * New code should avoid using Mochikit functions when possible, and use jQuery
> instead (hasElementClass, getNodeAttribute)

Ok. I did it but only for functions I added myself. I left the other one as is.

> * The call to self._is_event_droppable could probably go directly into the
> final TinyEvent call

Did it.

> * In the templates, TinyEvent.droppable is accessed 6 times (I think) and
> every single time it's in a conditional to decide on the right class to set.
> Maybe TinyEvent should have an additional droppable_class property which would
> directly return the right class for the event, no?

I started by adding an attribute to the div but I ran into some problems, which were probably related to something else. Since it's not always easy to debug javascript, I moved that atrribute to a new class. Perhaps that in the mean time, my problems were solved but I left that class. Now that code is running with the class, I could probably move it to an attribute again.

-- 
https://code.launchpad.net/~openerp-dev/openobject-client-web/trunk-cal-events-readonly/+merge/39348
Your team OpenERP SA's Web Client R&D is requested to review the proposed merge of lp:~openerp-dev/openobject-client-web/trunk-cal-events-readonly into lp:openobject-client-web.