← Back to team overview

openerp-dev-web team mailing list archive

Re: lp:~openerp-dev/openobject-client-web/Improvement_search_m2o into lp:openobject-client-web

 

Review: Needs Fixing
It's an alright start, but there are issues with it:

* The way the warning is displayed isn't very clear or nice, it should roughly display on top of the empty list, in black on white (in a warning box, basically) and instead of a Yes/No it should just have a [CREATE] or [CREATE ${record_name}] button on a line under it. Note that this makes the second part of the warning un-neded. So the message would look like:

    ——————————————————————————————————————————
   | The record ${record_name} does not exist.|
   |                                          |
   |          [Create ${record_name}]         |
    ——————————————————————————————————————————

  and should be at the center of the screen.

* There should not be a [No] option, especially not one closing the popup
* Clicking [Create] should actually do the same thing as the existing [New] button on the form: open a screen to create a record with the name pre-filled. This way, if there are other mandatory fields the client won't error out (which is what it currently does: if the object you're trying to create has other mandatory fields than the name, it will not work with the current system. So clicking [Create] in the warning box should just call the `do_create()` function, same as the [New] button.
-- 
https://code.launchpad.net/~openerp-dev/openobject-client-web/Improvement_search_m2o/+merge/40094
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-client-web/Improvement_search_m2o.



References