openerp-dev-web team mailing list archive

Thread
Date

Re: [Merge] lp:~openerp-dev/openobject-server/gpa-server-framework into lp:openobject-server

To: "gpa\(Open ERP\)" <gpa@xxxxxxxxxxx>
From: "Olivier Dony \(OpenERP\)" <odo@xxxxxxxxxxx>
Date: Wed, 24 Nov 2010 12:31:33 -0000
In-reply-to: <20101124111153.30176.8659.launchpad@loganberry.canonical.com>
Reply-to: mp+41707@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
Hello, this is much better!

One remaining issue: could you do the transformation of the icon file paths inside read_image() instead of hardcoding it during menu creation in convert.py? Also, we should not modify the file path in the database, it should still be the relative file name, not the full path.
This way we avoid storing a local path, and users can still backup/restore the database on different machines, move the addons directory around, etc.
Thanks!
-- 
https://code.launchpad.net/~openerp-dev/openobject-server/gpa-server-framework/+merge/41707
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-server/gpa-server-framework.

References

[Merge] lp:~openerp-dev/openobject-server/gpa-server-framework into lp:openobject-server
From: gpa(Open ERP), 2010-11-24