← Back to team overview

openerp-dev-web team mailing list archive

Re: [Merge] lp:~openerp-dev/openobject-addons/ssi-dev-addons1 into lp:~openerp-dev/openobject-addons/trunk-dev-addons1

 

Review: Needs Fixing
1) caldav/calendar.py:
@@ -769,7 +769,8 @@
remove '\' and newline. from "_('Can not create \
line "%s" more than once' % (vals.get('name'))))" 

2) crm/i18n/crm.pot:
@@ -2901,7 +2898,7 @@
remove '\n' from "Check if the category is limited to partners that match the segmentation criterions.\n"

3) fetchmail/fetchmail.py:
@@ -135,7 +135,7 @@
 it seem regression 

4) sale/sale.py
@@ -1057,7 +1057,7 @@
correct statement with 
warn msg += '\n\n' + _("EAN: %s") % str(ean) + _("Quantity: %s") % str(qty_pack) + _("Type of Shipping Unit: %s ") % str(type_ul.name)

and also correct msg_id on sale.pot:
"EAN:" => "EAN: %s"
"Quantity" => "Quantity: %s"

5) sale_crm/wizard/crm_make_sale.py:
@@ -107,7 +107,7 @@
put msg_id of this "Opportunity '%s' is converted to Quotation." in pot file

and also check message string should be available in pot file otherwise it could not be translate.

Thanks 
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/ssi-dev-addons1/+merge/41834
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/ssi-dev-addons1.



References