openerp-dev-web team mailing list archive

[xrg <xrg@xxxxxxxxx>]

Review: Needs Fixing
In translate.py:trans_load_data() there is a simple check of:
 res.lang.search( [('code','=', lang)])

In res.lang.install_lang() you should have performed the same check, because loading a new database *with* language set to anything, will break with the following 'blame':

module-file: base_data.xml
module-phase: file                                                                                     
module-mode: startup                                                                                   
context: base.startup                                                                                  
Exception type: DETAIL                                                                                 
Exception: duplicate key value violates unique constraint "res_lang_code_uniq" DETAIL:  Key (code)=(en_US) already exists.                                                                                    
regd-modules: ['base']                                                                                 
module: base

Please fix that and resubmit
-- 
https://code.launchpad.net/~openerp-dev/openobject-server/ysa-server-framework/+merge/44891
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-server/ysa-server-framework.