openerp-dev-web team mailing list archive

["Olivier Dony \(OpenERP\)" <odo@xxxxxxxxxxx>]

Review: Needs Fixing
Hello Yogesh, 

Nice work as usual :-)

A few things:
- what is this naming convention you often use: avil_id[s]? Do you mean it to be available_id[s]? Couldn't it just be lang_id[s] or object_ids or ids, depending on what it is, to make it more readable?

- For bug 670264, on first look it doesn't seem like your solution will work correctly, as you store the language in config['lang']. This means that after server restart it won't be set anymore, and it also means that it will have side-effects on other databases on the same server, doesn't it?
Could you instead store this default language in ir.values, like default values set by the user using the UI's 'set as default'. This way it's persistent, doesn't impact other databases, and you don't even need to change res.partner's _defaults as it will work automatically!

Thanks!
-- 
https://code.launchpad.net/~openerp-dev/openobject-server/ysa-server-framework/+merge/44949
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-server/ysa-server-framework.