openerp-dev-web team mailing list archive

["Olivier Dony \(OpenERP\)" <odo@xxxxxxxxxxx>]

Review: Needs Fixing
Hello,

- for change_password(), have you noticed that I had to patch your code to use the check() method to verify the password instead of reading it from the database? It is necessary for compatibility with base_crypt for example, because the password could be stored differently (LDAP, encrypted/hashed, etc.) so you cannot directly compare it. Could you reuse this technique?

- for the default partner language:
  + do you still need to set tools.config['lang'] in bin/service/web_services.py (line 359 of current diff)?
  + could you check that there is not already a default value before setting it? Otherwise it will always be the last language if several languages are installed.

- ir_ui_menu.read_image() : haven't you introduced an uninitialized variable "icon_image" (line 105 of current diff)?


Thanks!


PS: could you try to use "feature branches" instead of adding everything in a single long-living branch? ;-) Using shared-repositories make this quite easy and fast.
-- 
https://code.launchpad.net/~openerp-dev/openobject-server/ysa-server-framework/+merge/45029
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-server/ysa-server-framework.