← Back to team overview

openerp-dev-web team mailing list archive

lp:~openerp-dev/openobject-client-web/trunk-raise_rpc_errors-sma into lp:openobject-client-web

 

Sananaz (Open ERP) has proposed merging lp:~openerp-dev/openobject-client-web/trunk-raise_rpc_errors-sma into lp:openobject-client-web.

Requested reviews:
  OpenERP SA's Web Client R&D (openerp-dev-web)

For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-client-web/trunk-raise_rpc_errors-sma/+merge/49967

Hello,

Check with any addons module which raised osv exception.
Eg. Check with button action for bank statement, add statement lines with large amount 
and click on confirm, Gives exception like...
The statement balance is incorrect !

Thanks.


-- 
https://code.launchpad.net/~openerp-dev/openobject-client-web/trunk-raise_rpc_errors-sma/+merge/49967
Your team OpenERP SA's Web Client R&D is requested to review the proposed merge of lp:~openerp-dev/openobject-client-web/trunk-raise_rpc_errors-sma into lp:openobject-client-web.
=== modified file 'openobject/rpc/__init__.py'
--- openobject/rpc/__init__.py	2011-02-10 16:09:23 +0000
+++ openobject/rpc/__init__.py	2011-02-16 13:22:10 +0000
@@ -126,16 +126,16 @@
         except RPCException, err:
             if err.type in ('warning', 'UserError'):
                 if err.message in ('ConcurrencyException') and len(args) > 4:
-                    openobject.errors.Concurrency(err.message, err.data, args)
+                    raise openobject.errors.Concurrency(err.message, err.data, args)
                 else:
-                    openobject.errors.TinyWarning(err.data)
+                    raise openobject.errors.TinyWarning(err.data)
             elif err.code.startswith('AccessDenied'):
                 raise openobject.errors.AccessDenied(err.code, _('Access Denied'))
             else:
-                openobject.errors.TinyError(err.backtrace, _('Application Error'))
+                raise openobject.errors.TinyError(err.backtrace, _('Application Error'))
 
         except Exception, e:
-            openobject.errors.TinyError(str(e), _('Application Error'))
+            raise openobject.errors.TinyError(str(e), _('Application Error'))
 
     def execute(self, obj, method, *args):
         """Excecute the method of the obj with the given arguments.


Follow ups