← Back to team overview

openerp-dev-web team mailing list archive

Re: lp:~openerp-dev/openobject-client-web/trunk-bug-723157-jra into lp:openobject-client-web

 

> Actual review:
> 
> * Putting the folding button at the extreme right is good as that's consistent
> with other sidebars

> * Swapping around these elements and having the button sit in the middle of
> the bar is not, the button should be next to the folding/unfolding sign

Agree and put the 'More' button on next to the folding/unfolding sign.

> * These style informations should be in the CSS file, CSS inline in HTML
> should be avoided and I'm not sure there is a good reason to use it here.

Yes, I agree and Style information put in CSS file for only folding/unfolding sign, But for button 'More' we use it here because It's CSS Class Style information behave different on other places too (e.g. close button on widget panel).
-- 
https://code.launchpad.net/~openerp-dev/openobject-client-web/trunk-bug-723157-jra/+merge/51077
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-client-web/trunk-bug-723157-jra.



References