openerp-dev-web team mailing list archive

["Naresh\(OpenERP\)" <nch@xxxxxxxxxxx>]

Review: Needs Fixing
Hello Anup,

Looking at the diff it seems that the same thing we had before in stable and this was changed in 6.0 to support the user locale settings from res_lang.bringing back in the code will only create regressions, one of the most popular is when some one inserts date time using now() from the code which will have the micro seconds in their value {'date_test'': '2011-03-03 13:38:38.14} and your client will always crash resulting in  "ValueError: unconverted data remains: .14"

I think there was a bug report too for this but I dont remember it's link.

regarding the change that was done in 6.0
In 6.0 we checked the total length by converting the current date in the user's format self.fmt_length = len((DT.now()).strftime(self.format))

so that we can ignore the micro seconds or any other garbage after the seconds.

This will also help to specify the size too. 


for the problem what you are trying to fix you can check the trunk version. how it has been improved.


Thanks
-- 
https://code.launchpad.net/~openerp-dev/openobject-client/6.0-opw-date_format_save_issue-ach/+merge/52055
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-client/6.0-opw-date_format_save_issue-ach.