openerp-dev-web team mailing list archive

["Rucha \(Open ERP\)" <rpa@xxxxxxxxxxx>]

Review: Needs Fixing
Changes of converting old wizard with one2many field are "Approved"
but still something to improve (not your fault actually, its just an old code ;-), but needed to be improved)

1) label string in view:
    "Quantities you enter, match to products that will return to the stock."
    the sentence doesn't make sense, improve it
2) Inconsistent button names:
    "Return *with* Exchange" 
    "Refund *Without* Exchange"
    use proper cases
3) Instead of search and write for property field(in pos_return.py:line127-128) you can directly use get() method as in line:145
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-oldstyle-wiz-conversion-oldstyle-wiz-ron/+merge/52171
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-oldstyle-wiz-conversion.