← Back to team overview

openerp-dev-web team mailing list archive

Re: [Merge] lp:~openerp-dev/openobject-addons/6.0-bug-724198-jma into lp:openobject-addons/6.0

 

Review: Approve
Jenil,

This seems pretty consistent to what is being done by _get_invoice_type() of stock_picking.

However, your patch gives me a chance to tell the readers that reserved keywords should never be used for the role of a variable,its safe not to use them.

Thanks.

-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/6.0-bug-724198-jma/+merge/52835
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/6.0-bug-724198-jma.



References