← Back to team overview

openerp-dev-web team mailing list archive

Re: lp:~openerp-dev/openobject-client-web/trunk-bug-727874-jra into lp:openobject-client-web

 

Review: Disapprove
This piece of code was specifically moved out of the main applicative flow in revision xmo@xxxxxxxxxxx-20110212124629-bfps1b5m4fi6qb2m as it's the workaround of a bug, it has nothing to do with business logic or (in this case) redirection in and of itself.

Fixing the bug means fixing the moved code if it's incorrect (and indeed it is, it is looking for the Location header in the request headers instead of the response ones, and the tests made the same mistake therefore it passes its tests, but the tests are wrong), not reintroducing the old code.
-- 
https://code.launchpad.net/~openerp-dev/openobject-client-web/trunk-bug-727874-jra/+merge/52810
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-client-web/trunk-bug-727874-jra.



References