← Back to team overview

openerp-dev-web team mailing list archive

[Merge] lp:~openerp-dev/openobject-client-web/trunk-bug-4396-sma into lp:openobject-client-web

 

Sananaz (Open ERP) has proposed merging lp:~openerp-dev/openobject-client-web/trunk-bug-4396-sma into lp:openobject-client-web.

Requested reviews:
  OpenERP SA's Web Client R&D (openerp-dev-web)

For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-client-web/trunk-bug-4396-sma/+merge/53236

Hello,

Its maintenance case (ID:4396).
Description is:
Hello, i want change default language tu russian, but have an error:
A problem occurred in a Python script. Here is the sequence of function calls leading up to the error, in the order they occurred...
<type 'exceptions.ValueError'>: invalid literal for int() with base 10: '8888060@xxxxxx'
args = ("invalid literal for int() with base 10: '8888060@xxxxxx'",)
message = "invalid literal for int() with base 10: '8888060@xxxxxx'"

Please Check with:
- Install Russian Language > Go to Preferences > Add Email Id with (8888060@xxxxxx) and click on `OK`
- It gives traceback

Problem due to regular expression. I have resolve it with change the `re` of integer.
Also i have test with the bug(702568) for which we have used the `re`.
- https://bugs.launchpad.net/openobject-client-web/+bug/702568

Thank you.


-- 
https://code.launchpad.net/~openerp-dev/openobject-client-web/trunk-bug-4396-sma/+merge/53236
Your team OpenERP SA's Web Client R&D is requested to review the proposed merge of lp:~openerp-dev/openobject-client-web/trunk-bug-4396-sma into lp:openobject-client-web.
=== modified file 'addons/openerp/controllers/preferences.py'
--- addons/openerp/controllers/preferences.py	2011-02-10 16:09:23 +0000
+++ addons/openerp/controllers/preferences.py	2011-03-14 13:04:16 +0000
@@ -34,7 +34,7 @@
     action = "/openerp/pref/password"
     string = _('Change your password')
 
-int_pattern = re.compile(r'\d+')
+int_pattern = re.compile(r'^-{0,1}\d+$')
 class Preferences(Form):
 
     _cp_path = "/openerp/pref"


Follow ups