openerp-dev-web team mailing list archive

["Ashvin Rathod \(OpenERP\)" <ara@xxxxxxxxxxx>]

Ashvin Rathod (OpenERP) has proposed merging lp:~openerp-dev/openobject-addons/trunk-bug-740353-ara into lp:openobject-addons.

Requested reviews:
  OpenERP Core Team (openerp)
Related bugs:
  Bug #740353 in OpenERP Addons: "[account] dog slow invoice cancel because validate for every line; patch included"
  https://bugs.launchpad.net/openobject-addons/+bug/740353

For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-740353-ara/+merge/54669

Hello,

Fix: #740353 [account] dog slow invoice cancel because validate for every line; patch included 

Thanks,
ara
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-740353-ara/+merge/54669
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-740353-ara.

=== modified file 'account/account_move_line.py'
--- account/account_move_line.py	2011-03-03 14:59:00 +0000
+++ account/account_move_line.py	2011-03-24 10:00:51 +0000
@@ -1087,12 +1087,15 @@
         move_obj = self.pool.get('account.move')
         self._update_check(cr, uid, ids, context)
         result = False
+        move_ids = []
         for line in self.browse(cr, uid, ids, context=context):
+            if line.move_id not in move_ids:
+                move_ids.append(line.move_id.id)
             context['journal_id'] = line.journal_id.id
             context['period_id'] = line.period_id.id
             result = super(account_move_line, self).unlink(cr, uid, [line.id], context=context)
-            if check:
-                move_obj.validate(cr, uid, [line.move_id.id], context=context)
+        if check:
+            move_obj.validate(cr, uid, move_ids, context=context)
         return result
 
     def _check_date(self, cr, uid, vals, context=None, check=True):