← Back to team overview

openerp-dev-web team mailing list archive

[Merge] lp:~openerp-dev/openobject-addons/trunk-survey_fixes-uco into lp:openobject-addons

 

Ujjvala Collins (OpenERP) has proposed merging lp:~openerp-dev/openobject-addons/trunk-survey_fixes-uco into lp:openobject-addons.

Requested reviews:
  OpenERP Core Team (openerp)

For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-survey_fixes-uco/+merge/55486

[FIXES] Survey module:
================
1)) Surveys -> Define surveys -> Survey pages -> Ok button
Traceback (most recent call last):
  File "/home/uco/workspace/branches/rdtools/server/trunk/openerp/osv/osv.py", line 122, in wrapper
    return f(self, dbname, *args, **kwargs)
  File "/home/uco/workspace/branches/rdtools/server/trunk/openerp/osv/osv.py", line 176, in execute
    res = self.execute_cr(cr, uid, obj, method, *args, **kw)
  File "/home/uco/workspace/branches/rdtools/server/trunk/openerp/osv/osv.py", line 167, in execute_cr
    return getattr(object, method)(cr, uid, *args, **kw)
  File "/home/uco/workspace/branches/rdtools/addons/trunk/survey/survey.py", line 197, in survey_save
    surv_name_wiz.write(cr, uid, [context.get('sur_name_id',False)], {'transfer':True, 'page_no' : context.get('page_number',0) })
  File "/home/uco/workspace/branches/rdtools/server/trunk/openerp/osv/orm.py", line 1977, in write
    self.datas[object_id].update(vals2)
KeyError: False

2))
[2011-03-30 11:31:09,775][sur30] INFO:init:module survey: loading survey_demo.xml
  File "/home/uco/workspace/branches/rdtools/server/trunk/openerp/addons/base/ir/ir_model.py", line 602, in _get_id
    raise ValueError('No references to %s.%s' % (module, xml_id))
ValueError: No references to survey.group_survey_user

3)) Tools -> Reporting -> Surveys -> Browse Answers
  File "/home/uco/workspace/branches/rdtools/addons/trunk/survey/wizard/survey_answer.py", line 107, in fields_view_get
    and int(context['response_id'][0]) > 0:
TypeError: int() argument must be a string or a number, not 'list'

-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-survey_fixes-uco/+merge/55486
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-survey_fixes-uco.
=== modified file 'survey/survey_demo.xml'
--- survey/survey_demo.xml	2011-03-08 12:59:11 +0000
+++ survey/survey_demo.xml	2011-03-30 08:41:20 +0000
@@ -3,7 +3,7 @@
     <data noupdate="1">
 
         <record id="base.user_demo" model="res.users">
-            <field eval="[(4, ref('base.group_tool_user')),(4, ref('group_survey_user'))]" name="groups_id"/>
+            <field eval="[(4, ref('base.group_tool_user')),(4, ref('base.group_survey_user'))]" name="groups_id"/>
         </record>
 
         <record model="survey.type" id="survey_type1">

=== modified file 'survey/survey_view.xml'
--- survey/survey_view.xml	2011-03-10 13:07:51 +0000
+++ survey/survey_view.xml	2011-03-30 08:41:20 +0000
@@ -499,6 +499,7 @@
             <field name="name">survey_page_wizard_test</field>
             <field name="model">survey.page</field>
             <field name="type">form</field>
+            <field name="priority">20</field>
             <field name="arch" type="xml">
                 <form string="Survey Pages">
                     <field name="title" colspan="4" select="1"/>

=== modified file 'survey/wizard/survey_browse_answer.py'
--- survey/wizard/survey_browse_answer.py	2011-03-14 10:27:42 +0000
+++ survey/wizard/survey_browse_answer.py	2011-03-30 08:41:20 +0000
@@ -64,7 +64,7 @@
         record = self.read(cr, uid, ids, [])
         record = record and record[0] or {} 
         if record['response_id']:
-            res_id = [(record['response_id'])]
+            res_id = [(record['response_id'][0])]
         else:
             sur_response_obj = self.pool.get('survey.response')
             res_id = sur_response_obj.search(cr, uid, [('survey_id', '=',int(record['survey_id']))])


Follow ups