← Back to team overview

openerp-dev-web team mailing list archive

lp:~openerp-dev/openobject-server/6.0-bug-727730-delete-shortcut-vmt into lp:openobject-server/6.0

 

Vo Minh Thu (OpenERP) has proposed merging lp:~openerp-dev/openobject-server/6.0-bug-727730-delete-shortcut-vmt into lp:openobject-server/6.0.

Requested reviews:
  OpenERP Core Team (openerp)
Related bugs:
  Bug #727730 in OpenERP Server: "[6.0] unexisting shortcuts prohibt login"
  https://bugs.launchpad.net/openobject-server/+bug/727730

For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-server/6.0-bug-727730-delete-shortcut-vmt/+merge/56539

The change makes only sure the server returns shortcuts for existing menu entries. We probably have to delete the shortcuts when deleting its related meny entry. But I think to keep it for later.
-- 
https://code.launchpad.net/~openerp-dev/openobject-server/6.0-bug-727730-delete-shortcut-vmt/+merge/56539
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-server/6.0-bug-727730-delete-shortcut-vmt.
=== modified file 'bin/addons/base/ir/ir_ui_view.py'
--- bin/addons/base/ir/ir_ui_view.py	2011-01-15 04:50:58 +0000
+++ bin/addons/base/ir/ir_ui_view.py	2011-04-06 10:13:46 +0000
@@ -198,9 +198,11 @@
         ids = self.search(cr, uid, [('user_id','=',user_id),('resource','=',model)], context=context)
         results = self.read(cr, uid, ids, ['res_id'], context=context)
         name_map = dict(self.pool.get(model).name_get(cr, uid, [x['res_id'] for x in results], context=context))
-        for result in results:
+        # Make sure to return only shortcuts pointing to exisintg menu items.
+        filtered_results = filter(lambda result: result['res_id'] in name_map, results)
+        for result in filtered_results:
             result.update(name=name_map[result['res_id']])
-        return results
+        return filtered_results
 
     _order = 'sequence,name'
     _defaults = {


Follow ups