← Back to team overview

openerp-dev-web team mailing list archive

lp:~openerp-dev/openobject-server/trunk-cleanup-button-attributes-xmo into lp:openobject-server

 

Xavier (Open ERP) has proposed merging lp:~openerp-dev/openobject-server/trunk-cleanup-button-attributes-xmo into lp:openobject-server.

Requested reviews:
  OpenERP Core Team (openerp)

For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-cleanup-button-attributes-xmo/+merge/56542

Improvement of the rng schema for the <button/> element:

* Enumeration of all possible values for @type and @special to catch typos
* Removal of @target which is only used once and an error (discussed with odo)
-- 
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-cleanup-button-attributes-xmo/+merge/56542
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-cleanup-button-attributes-xmo.
=== modified file 'openerp/addons/base/rng/view.rng'
--- openerp/addons/base/rng/view.rng	2010-12-27 10:41:55 +0000
+++ openerp/addons/base/rng/view.rng	2011-04-06 10:29:23 +0000
@@ -545,11 +545,22 @@
             <rng:optional><rng:attribute name="icon" /></rng:optional>
             <rng:optional><rng:attribute name="string" /></rng:optional>
             <rng:optional><rng:attribute name="states" /></rng:optional>
-            <rng:optional><rng:attribute name="type" /></rng:optional>
-            <rng:optional><rng:attribute name="special" /></rng:optional>
+            <rng:optional>
+              <rng:attribute name="type">
+                <rng:choice>
+                  <rng:value>object</rng:value>
+                  <rng:value>action</rng:value>
+                  <rng:value>workflow</rng:value>
+                </rng:choice>
+              </rng:attribute>
+            </rng:optional>
+            <rng:optional>
+              <rng:attribute name="special">
+                <rng:value>cancel</rng:value>
+              </rng:attribute>
+            </rng:optional>
             <rng:optional><rng:attribute name="align" /></rng:optional>
             <rng:optional><rng:attribute name="colspan"/></rng:optional>
-            <rng:optional><rng:attribute name="target"/></rng:optional>
             <rng:optional><rng:attribute name="readonly"/></rng:optional>
             <rng:optional><rng:attribute name="context"/></rng:optional>
             <rng:optional><rng:attribute name="confirm"/></rng:optional>


Follow ups