← Back to team overview

openerp-dev-web team mailing list archive

lp:~openerp-dev/openobject-addons/addons-training-exam-result-firstpagee-report-ysa into lp:~openobject-training/openobject-addons/training

 

Yogesh(Open ERP) has proposed merging lp:~openerp-dev/openobject-addons/addons-training-exam-result-firstpagee-report-ysa into lp:~openobject-training/openobject-addons/training.

Requested reviews:
  OpenObject Training (openobject-training)

For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/addons-training-exam-result-firstpagee-report-ysa/+merge/57159

[FIX] training_exam:- fix problem of value checking in training_exam_result_firstpage report.
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/addons-training-exam-result-firstpagee-report-ysa/+merge/57159
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/addons-training-exam-result-firstpagee-report-ysa.
=== modified file 'training_exam/report/training_exam_result_firstpage.py'
--- training_exam/report/training_exam_result_firstpage.py	2011-02-17 08:29:51 +0000
+++ training_exam/report/training_exam_result_firstpage.py	2011-04-11 12:59:23 +0000
@@ -22,8 +22,9 @@
 
         partner_name = participation.partner_id.name.split()
         contact = participation.partner_id.notif_contact_id.contact_id
-        contact_name = contact.first_name.split() + contact.name.split()
-        contact_name_rev = contact.name.split() + contact.first_name.split()
+        first_name = contact.first_name and contact.first_name or ''
+        contact_name = first_name.split() + contact.name.split()
+        contact_name_rev = contact.name.split() + first_name.split()
 
         def compare_names(x, y):
             if len(x) <> len(y):

=== modified file 'training_exam/report/training_exam_result_firstpage.rml'
--- training_exam/report/training_exam_result_firstpage.rml	2009-12-31 11:15:40 +0000
+++ training_exam/report/training_exam_result_firstpage.rml	2011-04-11 12:59:23 +0000
@@ -78,7 +78,7 @@
         <td><para style="P8"><font color="white"> </font></para></td>
         <td>
           <para style="terp_default_10">[[ participation.partner_id.name ]]</para>
-          <para style="terp_default_10">[[ ((participation.partner_id.notif_contact_id and not is_private_person(participation)) and (participation.partner_id.notif_contact_id.contact_id.name + ' ' + participation.partner_id.notif_contact_id.contact_id.first_name) or removeParentNode('para')) ]]</para>
+          <para style="terp_default_10">[[ ((participation.partner_id.notif_contact_id and not is_private_person(participation)) and (participation.partner_id.notif_contact_id.contact_id.name + ' ' + (participation.partner_id.notif_contact_id.contact_id.first_name or '')) or removeParentNode('para')) ]]</para>
           <para style="terp_default_10">[[ (participation.partner_id.notif_contact_id and participation.partner_id.notif_contact_id.address_id.title) or '' ]]</para>
           <para style="terp_default_10">[[ (participation.partner_id.notif_contact_id and participation.partner_id.notif_contact_id.address_id.street) or '' ]]</para>
           <para style="terp_default_10">[[ (participation.partner_id.notif_contact_id and participation.partner_id.notif_contact_id.address_id.street2) or '' ]]</para>


Follow ups