openerp-dev-web team mailing list archive

Thread
Date

Re: [Merge] lp:~openerp-dev/openobject-addons/6.0-opw-5351-ach into lp:openobject-addons/6.0

To: "Anup\(OpenERP\)" <ach@xxxxxxxxxxx>
From: "Jay Vora \(OpenERP\)" <jvo@xxxxxxxxxxx>
Date: Thu, 21 Apr 2011 11:18:28 -0000
In-reply-to: <20110421110137.16681.42875.launchpad@loganberry.canonical.com>
Reply-to: mp+58651@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
Anup,

Did you try a case where the order date of sale order is earlier than the confirmation date?

This should be tested well.

I prefer, it should be confirmation date, because Procurement will be created only when SO is confirmed.

Moreover, I would like to see speed improvement here by not calling datetime object everytime under the shadow of for loop for Sale order Lines.

Thanks.
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/6.0-opw-5351-ach/+merge/58651
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/6.0-opw-5351-ach.

References

[Merge] lp:~openerp-dev/openobject-addons/6.0-opw-5351-ach into lp:openobject-addons/6.0
From: Anup(OpenERP), 2011-04-21