openerp-dev-web team mailing list archive
-
openerp-dev-web team
-
Mailing list archive
-
Message #05917
Re: [Merge] lp:~openerp-dev/openobject-addons/6.0-opw-4972-ach into lp:openobject-addons/6.0
Review: Needs Fixing
Anup,
Thanks for the fix, good job.
However, there few little point to improve.
1. Line 9 and 19. It should be context.get(key,1).
2. We need the LOT field mandatory by default when the concerned product is set to be traced for production. Adding a field of type dummy and showing its effect on on_change would do. Give a try.
3. Line 68. It cannot be 'can not' !
Thanks.
--
https://code.launchpad.net/~openerp-dev/openobject-addons/6.0-opw-4972-ach/+merge/59021
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/6.0-opw-4972-ach.
References