← Back to team overview

openerp-dev-web team mailing list archive

lp:~openerp-dev/openobject-addons/addons-training-course-categ-constrain-imp-view-evaluation-ysa into lp:~openobject-training/openobject-addons/training

 

Yogesh(Open ERP) has proposed merging lp:~openerp-dev/openobject-addons/addons-training-course-categ-constrain-imp-view-evaluation-ysa into lp:~openobject-training/openobject-addons/training.

Requested reviews:
  OpenObject Training (openobject-training)

For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/addons-training-course-categ-constrain-imp-view-evaluation-ysa/+merge/59171

[FIX] training :- add check_recursion constrain in training_course_category object. improve view preview evaluation wizard.
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/addons-training-course-categ-constrain-imp-view-evaluation-ysa/+merge/59171
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/addons-training-course-categ-constrain-imp-view-evaluation-ysa.
=== modified file 'training/training.py'
--- training/training.py	2011-04-26 06:36:47 +0000
+++ training/training.py	2011-04-27 06:29:27 +0000
@@ -114,6 +114,21 @@
         'child_ids': fields.one2many('training.course_category', 'parent_id', 'Child Accounts')
     }
 
+
+    def _check_recursion(self, cr, uid, ids, context=None):
+        level = 100
+        while len(ids):
+            cr.execute('select distinct parent_id from training_course_category where id in ('+','.join(map(str,ids))+')')
+            ids = filter(None, map(lambda x:x[0], cr.fetchall()))
+            if not level:
+                return False
+            level -= 1
+        return True
+
+    _constraints = [
+        (_check_recursion, 'Error! You can not create recursive Course Categories.', ['parent_id'])
+    ]
+
     def name_get(self, cr, uid, ids, context=None):
         if not len(ids):
             return []

=== modified file 'training_evaluation/wizard/wizard_preview_evaluation_view.xml'
--- training_evaluation/wizard/wizard_preview_evaluation_view.xml	2011-04-08 11:07:04 +0000
+++ training_evaluation/wizard/wizard_preview_evaluation_view.xml	2011-04-27 06:29:27 +0000
@@ -11,8 +11,9 @@
                 <field name="eval_quizz_id" invisible="1"/>
                 <separator colspan="4"/>
                 <group colspan="4">
+                    <label colspan="2"/>
 	                <button type="special" special="cancel" string="Cancel" icon="gtk-cancel"/>
-	                <button type="object" name="button_print" string="Print" colspan="2"/>
+	                <button type="object" name="button_print" string="Print" icon="gtk-print"/>
                 </group>
             </form>
         </field>


Follow ups