openerp-dev-web team mailing list archive

["Rucha \(Open ERP\)" <rpa@xxxxxxxxxxx>]

Review: Needs Fixing

1) needed some code refactoring and optimization, 
2) make sure your changes doesn't touch other code (line: 23, 31, 103, 112 of diff of this merge proposal)
3) Put some nice comments in code, so on a quick read of code, one can understand the logic/reason of code (low priority for now)
4) Move unlink to other feature branch
   (Improve it: 
     1. Avoid too many looping
           + for id in ids:
              + for data in self.browse(cr, uid, ids ,context=context):
     2. return inside loop is not good at all)
-- 
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-temporal-db-ksa/+merge/59035
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-temporal-db.