← Back to team overview

openerp-dev-web team mailing list archive

Re: [Merge] lp:~openerp-dev/openobject-server/6.0-opw-5480-ach into lp:openobject-server/6.0

 

On Friday 29 April 2011, you wrote:
> Anup(OpenERP) has proposed merging
> lp:~openerp-dev/openobject-server/6.0-opw-5480-ach into
> lp:openobject-server/6.0.
> 
> Requested reviews:
>   Olivier Dony (OpenERP) (odo)
>   Jay Vora (OpenERP) (jvo-openerp)

That change makes perfect sense. Looks good (although I haven't tested it yet 
myself).

One thing to ask: is the [:size-3] operation performed on a unicode or on a 
utf8 string? In the latter case, it could cut the byte string in the middle of 
a char. So, better make sure it only operates on unicode strings. 


-- 
Say NO to spam and viruses. Stop using Microsoft Windows!

https://code.launchpad.net/~openerp-dev/openobject-server/6.0-opw-5480-ach/+merge/59502
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-server/6.0-opw-5480-ach.


References