openerp-dev-web team mailing list archive

["Jay Vora \(OpenERP\)" <jvo@xxxxxxxxxxx>]

Review: Needs Fixing
Anup,

Thank you for the fix.

Kindly note :
1. You can combine line 25 and 26 to be : 
   proj_uom_id = procurement.company_id.project_time_mode_id.id
   System will return False if there is no unit configured.

2. Line 28 : 'Configuration Error!' sounds better.
3. Line 29 : Isn't that advisable to call the function only when the UoMs differ?

Thanks.
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/6.0-opw-5267-project_mrp-ach/+merge/59732
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/6.0-opw-5267-project_mrp-ach.