openerp-dev-web team mailing list archive

["Mustufa Rangwala \(Open ERP\)" <mra@xxxxxxxxxxx>]

Review: Needs Fixing
1. rename both the function to "sum"]
2. def worked_days_sum => move this method to work days object.
3. if not employee: => return 0.0 not 0
4. browse in for loop ?
5. This should be improve:

            if field == 'number_of_days':
                result +=  input_line.number_of_days
            elif field == 'number_of_hours':
                result +=  input_line.number_of_hours
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-payslip-on-payslip-mtr/+merge/60022
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-payroll.