openerp-dev-web team mailing list archive

["Jacques-Etienne Baudoux \(OpenERP\)" <jba@xxxxxxxxxxx>]

Review: Disapprove
I don't think it will work. If you have 'variant' in the context (line 639), it's calling only create and never calling copy_translations.

The minor other things Olivier told you are still remaining:
- why the funky indentation in copy_translation()? ;-)
- as a good practice, do not alter the original context, please use a copy, otherwise you might create side-effects when you modify/remove the language, for example if the RPC call does something else afterwards.
630	context_without_lang = context.copy()
631	if 'lang' in context_without_lang:
632	    del context_without_lang['lang'] 
633	product = self.read(cr, uid, id, ['name'], context=context_without_lang)

651	            return super(product_product, self).copy(cr, uid, id, default=default,
652	                    context=context)
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/6.0-opw_bug-734191-ach/+merge/56116
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/6.0-opw_bug-734191-ach.