openerp-dev-web team mailing list archive

["Xavier \(Open ERP\)" <xmo@xxxxxxxxxxx>]

Review: Needs Fixing
Two additions to xrg's comments (which needs to be fixed):

* Is there any way for `defval` to be a dict rather than a list? If `defval` is either a list or a value type, there is no reason for KeyError to happen.

* If most of the values are strings or integers (rather than list), letting it throw exceptions all the time obscures the code and is not as efficient as LBYL.
-- 
https://code.launchpad.net/~openerp-dev/openobject-client-web/trunk-bug-754645-jra/+merge/59205
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-client-web/trunk-bug-754645-jra.