← Back to team overview

openerp-dev-web team mailing list archive

Re: lp:~openerp-dev/openobject-server/server-6.0-training-bugfixes into lp:openobject-server/6.0

 

Review: Disapprove
Hi,

The tuple->list conversion seems a bit fragile. Unless there is a compelling reason to do so, this will not be accepted. Anyway, a separate merge proposal would be needed.

The link attribute on the field element is a fragile, unsupported feature. Also, it gives only a false sense of security.

The IndexError will be corrected on its own.

Still, thanks for the merge proposal.
-- 
https://code.launchpad.net/~openerp-dev/openobject-server/server-6.0-training-bugfixes/+merge/59206
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-server/server-6.0-training-bugfixes.


References