openerp-dev-web team mailing list archive

["Rucha \(Open ERP\)" <rpa@xxxxxxxxxxx>]

Review: Needs Fixing
1) line 21-22, context has to be removed as per previous comment

2) def set_date...
   if this function is called for ids [1, 2] its finding for the recent child records for 1 and 2 and assigns result to that ids, not to ids 1 and 2

3) def get_next_id_in_timeline..
    ('temporal_date_from', '=', record.temporal_date_from) should be ('temporal_date_to', '=', record.temporal_date_from)
    as we need to find the previous record

4) def write..
    remove context.update({'temporal_date_from': timenow}) if not used anywhere

5) def write..
    Improve function to remove ids.pop() 
-- 
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-temporal-db-read-search-unlink-ksa/+merge/60367
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-temporal-db.