← Back to team overview

openerp-dev-web team mailing list archive

Re: [Merge] lp:~openerp-dev/openobject-server/trunk-bugfix-781190 into lp:openobject-server

 

- import sys, traceback, pformat in the first file seems unnecessary...
done
- still in the first file, I guess you want depth=depth
removed
- still in the first file, are you sure you want fn='object.execute', and not '%s,%s'%(model,func) ?
yes, I'm sure
- in the second file, are you sure you want to remove service, method, params?
yes, one line is enough
- not exactly the same, but is this ok ? :)
	+ indent=fn
          indent_after = ' ' * len(fn)
	+ for line in (pformat(msg, depth=depth)).split('\n'):
	+   logger.log(channel, indent+line)
	+   indent=indent_after
improved
-- 
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-bugfix-781190/+merge/60660
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-bugfix-781190.


References