openerp-dev-web team mailing list archive

["Ujjvala Collins \(OpenERP\)" <uco@xxxxxxxxxxx>]

Ujjvala Collins (OpenERP) has proposed merging lp:~openerp-dev/openobject-addons/trunk-account-asset-invoice_asset_state-uco into lp:~openerp-dev/openobject-addons/trunk-account-asset.

Requested reviews:
  OpenERP R&D Team (openerp-dev)

For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-account-asset-invoice_asset_state-uco/+merge/61369

[ADD] account_asset:
-------------------------------------
* Add a boolean 'skip draft state for asset when created by invoice'
* Put a m2o(asset category) on invoice line instead of m2o(asset)
* When confirming an invoice, if there are asset categories on invoice line, then create an asset in draft with that category, name = invoice line name (+product if availalble). If the boolean "skip draft state" of the category is true, then confirm automatically the asset
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-account-asset-invoice_asset_state-uco/+merge/61369
Your team OpenERP R&D Team is requested to review the proposed merge of lp:~openerp-dev/openobject-addons/trunk-account-asset-invoice_asset_state-uco into lp:~openerp-dev/openobject-addons/trunk-account-asset.

=== modified file 'account_asset/account_asset.py'
--- account_asset/account_asset.py	2011-05-13 10:15:23 +0000
+++ account_asset/account_asset.py	2011-05-18 09:48:33 +0000
@@ -37,6 +37,7 @@
         'account_expense_depreciation_id': fields.many2one('account.account', 'Depr. Expense Account', required=True),
         'journal_id': fields.many2one('account.journal', 'Journal', required=True),
         'company_id': fields.many2one('res.company', 'Company', required=True),
+        'skip_draft_state': fields.boolean('Skip Draft State', help="Skips draft state for asset when created by invoice."),
     }
 
     _defaults = {

=== modified file 'account_asset/account_asset_invoice.py'
--- account_asset/account_asset_invoice.py	2011-03-30 13:25:27 +0000
+++ account_asset/account_asset_invoice.py	2011-05-18 09:48:33 +0000
@@ -26,20 +26,28 @@
     _inherit = 'account.invoice'
     def line_get_convert(self, cr, uid, x, part, date, context={}):
         res = super(account_invoice, self).line_get_convert(cr, uid, x, part, date, context)
-        res['asset_id'] = x.get('asset_id', False)
+        res['asset_category_id'] = x.get('asset_category_id', False)
         return res
 account_invoice()
 
 class account_invoice_line(osv.osv):
     _inherit = 'account.invoice.line'
     _columns = {
-        'asset_id': fields.many2one('account.asset.asset', 'Asset'),
+        'asset_category_id': fields.many2one('account.asset.category', 'Asset Category'),
     }
     def move_line_get_item(self, cr, uid, line, context={}):
         res = super(account_invoice_line, self).move_line_get_item(cr, uid, line, context)
-        res['asset_id'] = line.asset_id.id or False
-        if line.asset_id.id and (line.asset_id.state=='draft'):
-            self.pool.get('account.asset.asset').validate(cr, uid, [line.asset_id.id], context)
+        res['asset_category_id'] = line.asset_category_id.id or False
+        asset_obj = self.pool.get('account.asset.asset')
+        if line.asset_category_id.id:
+            vals = {
+                'name': line.product_id and (line.name + ": " + line.product_id.name) or line.name,
+                'category_id': line.asset_category_id.id,
+                'purchase_value': line.price_subtotal
+            }
+            asset_id = asset_obj.create(cr, uid, vals, context=context)
+            if line.asset_category_id.skip_draft_state:
+                asset_obj.validate(cr, uid, [asset_id], context=context)
         return res
 account_invoice_line()
 

=== modified file 'account_asset/account_asset_invoice_view.xml'
--- account_asset/account_asset_invoice_view.xml	2011-03-30 13:25:27 +0000
+++ account_asset/account_asset_invoice_view.xml	2011-05-18 09:48:33 +0000
@@ -13,7 +13,7 @@
         <field name="type">form</field>
         <field name="arch" type="xml">
             <field name="invoice_line_tax_id" position="before">
-                <field name="asset_id" context="name=name"/>
+                <field name="asset_category_id" context="name=name"/>
             </field>
         </field>
     </record>

=== modified file 'account_asset/account_asset_view.xml'
--- account_asset/account_asset_view.xml	2011-05-13 10:15:23 +0000
+++ account_asset/account_asset_view.xml	2011-05-18 09:48:33 +0000
@@ -15,6 +15,7 @@
                 <field name="account_asset_id"/>
                 <field name="account_depreciation_id"/>
                 <field name="account_expense_depreciation_id"/>
+                <field name="skip_draft_state"/>
         	<group col="4" colspan="4" groups="analytic.group_analytic_accounting">
         	    <separator string="Analytic information" colspan="4" />
         	    <newline/>