openerp-dev-web team mailing list archive

["RavishchandraMurari\(OpenERP\)" <rmu@xxxxxxxxxxx>]

RavishchandraMurari(OpenERP) has proposed merging lp:~openerp-dev/openobject-client-web/trunk-usability-remove_technical_tool_tips-rmu into lp:~openerp-dev/openobject-client-web/trunk-usability.

Requested reviews:
  OpenERP R&D Team (openerp-dev)

For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-client-web/trunk-usability-remove_technical_tool_tips-rmu/+merge/61403
-- 
https://code.launchpad.net/~openerp-dev/openobject-client-web/trunk-usability-remove_technical_tool_tips-rmu/+merge/61403
Your team OpenERP R&D Team is requested to review the proposed merge of lp:~openerp-dev/openobject-client-web/trunk-usability-remove_technical_tool_tips-rmu into lp:~openerp-dev/openobject-client-web/trunk-usability.

=== modified file 'addons/openerp/static/javascript/openerp/openerp.ui.tips.js'
--- addons/openerp/static/javascript/openerp/openerp.ui.tips.js	2011-01-17 11:57:11 +0000
+++ addons/openerp/static/javascript/openerp/openerp.ui.tips.js	2011-05-18 13:31:14 +0000
@@ -71,8 +71,6 @@
         
             el = openobject.dom.get(el);
             el.myText = MochiKit.DOM.getNodeAttribute(el, 'title');
-            el.tipModel = MochiKit.DOM.getNodeAttribute(el, 'model');
-            el.tipField = MochiKit.DOM.getNodeAttribute(el, 'fname');
 
             if (el.myText)
                 el.removeAttribute('title');
@@ -108,8 +106,6 @@
 
         var text = el.myText;
         var title = el.myTitle;
-        var model = el.tipModel || ''
-        var fieldname = el.tipField || ''
 
         // if plain text then replace \n with <br>
         if (! /<\w+/.test(text)) {
@@ -119,8 +115,6 @@
         title = text ? title : '';
 
         this.toolTitle.innerHTML = title;
-        this.toolModel.innerHTML = model;
-        this.toolField.innerHTML = fieldname;
 
         if (/msie/.test(navigator.userAgent.toLowerCase())) { // hack for strange IE error
             var div = document.createElement('div');
@@ -179,8 +173,6 @@
     }
     var elements = MochiKit.Base.filter(function(e){
         var text = MochiKit.DOM.getNodeAttribute(e, 'title');
-        var model = MochiKit.DOM.getNodeAttribute(e, 'model');
-        var fname = MochiKit.DOM.getNodeAttribute(e, 'fname') || '';
         var fieldname = fname && fname.indexOf('/') == -1 ? fname : fname.split(/[/ ]+/).pop();
         if(!text)
             text = '';
@@ -197,8 +189,6 @@
         }
 
         MochiKit.DOM.setNodeAttribute(e, 'title', title + '::' + text);
-        MochiKit.DOM.setNodeAttribute(e, 'model', model);
-        MochiKit.DOM.setNodeAttribute(e, 'fname', fieldname);
         return true;
 
     }, openobject.dom.select('td.label', document));