openerp-dev-web team mailing list archive

Thread
Date

Re: lp:~openerp-dev/openobject-addons/trunk-payroll-python-code-browse-using-dot-mtr into lp:~openerp-dev/openobject-addons/trunk-payroll

To: "Meera Trambadia \(OpenERP\)" <mtr@xxxxxxxxxxx>
From: "Mustufa Rangwala \(Open ERP\)" <mra@xxxxxxxxxxx>
Date: Mon, 23 May 2011 07:09:23 -0000
In-reply-to: <20110519054432.17286.45288.launchpad@loganberry.canonical.com>
Reply-to: mp+61506@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
categories_obj = Categories(self.pool, cr, uid, payslip.employee_id.id, categories_dict)  &
localdict['categories'] = categories_obj
 => i think no need to initialize this in for loop ...when your categories_dict is ready you can create object outside the for loop.

can you check.
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-python-code-browse-using-dot-mtr/+merge/61506
Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-payroll.

References

lp:~openerp-dev/openobject-addons/trunk-payroll-python-code-browse-using-dot-mtr into lp:~openerp-dev/openobject-addons/trunk-payroll
From: Meera Trambadia (OpenERP), 2011-05-19